aboutsummaryrefslogtreecommitdiffstats
path: root/contrib/ntp/sntp/tests/packetProcessing.c
diff options
context:
space:
mode:
Diffstat (limited to 'contrib/ntp/sntp/tests/packetProcessing.c')
-rw-r--r--contrib/ntp/sntp/tests/packetProcessing.c196
1 files changed, 107 insertions, 89 deletions
diff --git a/contrib/ntp/sntp/tests/packetProcessing.c b/contrib/ntp/sntp/tests/packetProcessing.c
index 88e61cc89d91..660b5b6e20f1 100644
--- a/contrib/ntp/sntp/tests/packetProcessing.c
+++ b/contrib/ntp/sntp/tests/packetProcessing.c
@@ -1,10 +1,5 @@
#include "config.h"
-/* need autokey for some of the tests, or the will create buffer overruns. */
-#ifndef AUTOKEY
-# define AUTOKEY 1
-#endif
-
#include "sntptest.h"
#include "networking.h"
#include "ntp_stdlib.h"
@@ -13,7 +8,7 @@
const char * Version = "stub unit test Version string";
-// Hacks into the key database.
+/* Hacks into the key database. */
extern struct key* key_ptr;
extern int key_cnt;
@@ -41,9 +36,25 @@ void test_CorrectUnauthenticatedPacket(void);
void test_CorrectAuthenticatedPacketMD5(void);
void test_CorrectAuthenticatedPacketSHA1(void);
+/* [Bug 2998] There are some issues whith the definition of 'struct pkt'
+ * when AUTOKEY is undefined -- the formal struct is too small to hold
+ * all the extension fields that are going to be tested. We have to make
+ * sure we have the extra bytes, or the test yield undefined results due
+ * to buffer overrun.
+ */
+#ifndef AUTOKEY
+# define EXTRA_BUFSIZE 256
+#else
+# define EXTRA_BUFSIZE 0
+#endif
+
+union tpkt {
+ struct pkt p;
+ u_char b[sizeof(struct pkt) + EXTRA_BUFSIZE];
+};
-static struct pkt testpkt;
-static struct pkt testspkt;
+static union tpkt testpkt;
+static union tpkt testspkt;
static sockaddr_u testsock;
bool restoreKeyDb;
@@ -95,10 +106,10 @@ setUp(void)
/* Initialize the test packet and socket,
* so they contain at least some valid data.
*/
- testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING, NTP_VERSION,
+ testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING, NTP_VERSION,
MODE_SERVER);
- testpkt.stratum = STRATUM_REFCLOCK;
- memcpy(&testpkt.refid, "GPS\0", 4);
+ testpkt.p.stratum = STRATUM_REFCLOCK;
+ memcpy(&testpkt.p.refid, "GPS\0", 4);
/* Set the origin timestamp of the received packet to the
* same value as the transmit timestamp of the sent packet.
@@ -107,8 +118,8 @@ setUp(void)
tmp.l_ui = 1000UL;
tmp.l_uf = 0UL;
- HTONL_FP(&tmp, &testpkt.org);
- HTONL_FP(&tmp, &testspkt.xmt);
+ HTONL_FP(&tmp, &testpkt.p.org);
+ HTONL_FP(&tmp, &testspkt.p.xmt);
}
@@ -129,11 +140,11 @@ void
test_TooShortLength(void)
{
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC - 1,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC - 1,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC - 1,
- MODE_BROADCAST, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC - 1,
+ MODE_BROADCAST, &testspkt.p, "UnitTest"));
}
@@ -141,22 +152,29 @@ void
test_LengthNotMultipleOfFour(void)
{
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC + 6,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC + 6,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC + 3,
- MODE_BROADCAST, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC + 3,
+ MODE_BROADCAST, &testspkt.p, "UnitTest"));
}
void
test_TooShortExtensionFieldLength(void)
{
+ /* [Bug 2998] We have to get around the formal specification of
+ * the extension field if AUTOKEY is undefined. (At least CLANG
+ * issues a warning in this case. It's just a warning, but
+ * still...
+ */
+ uint32_t * pe = testpkt.p.exten + 7;
+
/* The lower 16-bits are the length of the extension field.
* This lengths must be multiples of 4 bytes, which gives
* a minimum of 4 byte extension field length.
*/
- testpkt.exten[7] = htonl(3); /* 3 bytes is too short. */
+ *pe = htonl(3); /* 3 bytes is too short. */
/* We send in a pkt_len of header size + 4 byte extension
* header + 24 byte MAC, this prevents the length error to
@@ -165,8 +183,8 @@ test_TooShortExtensionFieldLength(void)
int pkt_len = LEN_PKT_NOMAC + 4 + 24;
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -181,8 +199,8 @@ test_UnauthenticatedPacketReject(void)
/* We demand authentication, but no MAC header is present. */
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -196,8 +214,8 @@ test_CryptoNAKPacketReject(void)
int pkt_len = LEN_PKT_NOMAC + 4; /* + 4 byte MAC = Crypto-NAK */
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -211,19 +229,19 @@ test_AuthenticatedPacketInvalid(void)
/* Prepare the packet. */
int pkt_len = LEN_PKT_NOMAC;
- testpkt.exten[0] = htonl(50);
- int mac_len = make_mac(&testpkt, pkt_len,
+ testpkt.p.exten[0] = htonl(50);
+ int mac_len = make_mac(&testpkt.p, pkt_len,
MAX_MD5_LEN, key_ptr,
- &testpkt.exten[1]);
+ &testpkt.p.exten[1]);
pkt_len += 4 + mac_len;
/* Now, alter the MAC so it becomes invalid. */
- testpkt.exten[1] += 1;
+ testpkt.p.exten[1] += 1;
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -239,15 +257,15 @@ test_AuthenticatedPacketUnknownKey(void)
*/
int pkt_len = LEN_PKT_NOMAC;
- testpkt.exten[0] = htonl(50);
- int mac_len = make_mac(&testpkt, pkt_len,
+ testpkt.p.exten[0] = htonl(50);
+ int mac_len = make_mac(&testpkt.p, pkt_len,
MAX_MD5_LEN, key_ptr,
- &testpkt.exten[1]);
+ &testpkt.p.exten[1]);
pkt_len += 4 + mac_len;
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -256,16 +274,16 @@ test_ServerVersionTooOld(void)
{
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
- testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
- NTP_OLDVERSION - 1,
- MODE_CLIENT);
- TEST_ASSERT_TRUE(PKT_VERSION(testpkt.li_vn_mode) < NTP_OLDVERSION);
+ testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
+ NTP_OLDVERSION - 1,
+ MODE_CLIENT);
+ TEST_ASSERT_TRUE(PKT_VERSION(testpkt.p.li_vn_mode) < NTP_OLDVERSION);
int pkt_len = LEN_PKT_NOMAC;
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -274,16 +292,16 @@ test_ServerVersionTooNew(void)
{
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
- testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
- NTP_VERSION + 1,
- MODE_CLIENT);
- TEST_ASSERT_TRUE(PKT_VERSION(testpkt.li_vn_mode) > NTP_VERSION);
+ testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
+ NTP_VERSION + 1,
+ MODE_CLIENT);
+ TEST_ASSERT_TRUE(PKT_VERSION(testpkt.p.li_vn_mode) > NTP_VERSION);
int pkt_len = LEN_PKT_NOMAC;
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -292,16 +310,16 @@ test_NonWantedMode(void)
{
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
- testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
- NTP_VERSION,
- MODE_CLIENT);
+ testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
+ NTP_VERSION,
+ MODE_CLIENT);
/* The packet has a mode of MODE_CLIENT, but process_pkt expects
* MODE_SERVER
*/
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -311,12 +329,12 @@ test_KoDRate(void)
{
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
- testpkt.stratum = STRATUM_PKT_UNSPEC;
- memcpy(&testpkt.refid, "RATE", 4);
+ testpkt.p.stratum = STRATUM_PKT_UNSPEC;
+ memcpy(&testpkt.p.refid, "RATE", 4);
TEST_ASSERT_EQUAL(KOD_RATE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -325,12 +343,12 @@ test_KoDDeny(void)
{
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
- testpkt.stratum = STRATUM_PKT_UNSPEC;
- memcpy(&testpkt.refid, "DENY", 4);
+ testpkt.p.stratum = STRATUM_PKT_UNSPEC;
+ memcpy(&testpkt.p.refid, "DENY", 4);
TEST_ASSERT_EQUAL(KOD_DEMOBILIZE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -339,13 +357,13 @@ test_RejectUnsyncedServer(void)
{
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
- testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOTINSYNC,
- NTP_VERSION,
- MODE_SERVER);
+ testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOTINSYNC,
+ NTP_VERSION,
+ MODE_SERVER);
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -357,15 +375,15 @@ test_RejectWrongResponseServerMode(void)
l_fp tmp;
tmp.l_ui = 1000UL;
tmp.l_uf = 0UL;
- HTONL_FP(&tmp, &testpkt.org);
+ HTONL_FP(&tmp, &testpkt.p.org);
tmp.l_ui = 2000UL;
tmp.l_uf = 0UL;
- HTONL_FP(&tmp, &testspkt.xmt);
+ HTONL_FP(&tmp, &testspkt.p.xmt);
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -374,12 +392,12 @@ test_AcceptNoSentPacketBroadcastMode(void)
{
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
- testpkt.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
- NTP_VERSION,
- MODE_BROADCAST);
+ testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
+ NTP_VERSION,
+ MODE_BROADCAST);
TEST_ASSERT_EQUAL(LEN_PKT_NOMAC,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
MODE_BROADCAST, NULL, "UnitTest"));
}
@@ -390,8 +408,8 @@ test_CorrectUnauthenticatedPacket(void)
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
TEST_ASSERT_EQUAL(LEN_PKT_NOMAC,
- process_pkt(&testpkt, &testsock, LEN_PKT_NOMAC,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -404,16 +422,16 @@ test_CorrectAuthenticatedPacketMD5(void)
int pkt_len = LEN_PKT_NOMAC;
/* Prepare the packet. */
- testpkt.exten[0] = htonl(10);
- int mac_len = make_mac(&testpkt, pkt_len,
+ testpkt.p.exten[0] = htonl(10);
+ int mac_len = make_mac(&testpkt.p, pkt_len,
MAX_MD5_LEN, key_ptr,
- &testpkt.exten[1]);
+ &testpkt.p.exten[1]);
pkt_len += 4 + mac_len;
TEST_ASSERT_EQUAL(pkt_len,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}
@@ -426,14 +444,14 @@ test_CorrectAuthenticatedPacketSHA1(void)
int pkt_len = LEN_PKT_NOMAC;
/* Prepare the packet. */
- testpkt.exten[0] = htonl(20);
- int mac_len = make_mac(&testpkt, pkt_len,
+ testpkt.p.exten[0] = htonl(20);
+ int mac_len = make_mac(&testpkt.p, pkt_len,
MAX_MAC_LEN, key_ptr,
- &testpkt.exten[1]);
+ &testpkt.p.exten[1]);
pkt_len += 4 + mac_len;
TEST_ASSERT_EQUAL(pkt_len,
- process_pkt(&testpkt, &testsock, pkt_len,
- MODE_SERVER, &testspkt, "UnitTest"));
+ process_pkt(&testpkt.p, &testsock, pkt_len,
+ MODE_SERVER, &testspkt.p, "UnitTest"));
}