POSIX compliance improvements in the pthread(3) functions.

This basically adds makes use of the C99 restrict keyword, and also
adds some 'const's to four threading functions: pthread_mutexattr_gettype(),
pthread_mutexattr_getprioceiling(), pthread_mutexattr_getprotocol(), and
pthread_mutex_getprioceiling. The changes are in accordance to POSIX/SUSv4-2018.

Hinted by:	DragonFlyBSD

Relnotes:	yes
MFC after:	1 month
Differential Revision:	D16722

1 files changed, 54 insertions, 37 deletions

diff --git a/include/pthread.h b/include/pthread.h
index c58a9fe5e360..c22ad216d01b 100644
--- a/include/pthread.h
+++ b/include/pthread.h
@@ -153,10 +153,10 @@ int		pthread_attr_destroy(pthread_attr_t *);
 int		pthread_attr_getstack(
 		    const pthread_attr_t * __restrict, void ** __restrict,
 		    size_t * __restrict);
-int		pthread_attr_getstacksize(const pthread_attr_t *,
-		    size_t *);
-int		pthread_attr_getguardsize(const pthread_attr_t *,
-		    size_t *);
+int		pthread_attr_getstacksize(const pthread_attr_t * __restrict,
+		    size_t * __restrict);
+int		pthread_attr_getguardsize(const pthread_attr_t * __restrict,
+		    size_t * __restrict);
 int		pthread_attr_getstackaddr(const pthread_attr_t *, void **);
 int		pthread_attr_getdetachstate(const pthread_attr_t *,
 		    int *);
@@ -168,12 +168,12 @@ int		pthread_attr_setstack(pthread_attr_t *, void *,
 int		pthread_attr_setstackaddr(pthread_attr_t *, void *);
 int		pthread_attr_setdetachstate(pthread_attr_t *, int);
 int		pthread_barrier_destroy(pthread_barrier_t *);
-int		pthread_barrier_init(pthread_barrier_t *,
-			const pthread_barrierattr_t *, unsigned);
+int		pthread_barrier_init(pthread_barrier_t * __restrict,
+			const pthread_barrierattr_t * __restrict, unsigned);
 int		pthread_barrier_wait(pthread_barrier_t *);
 int		pthread_barrierattr_destroy(pthread_barrierattr_t *);
 int		pthread_barrierattr_getpshared(
-		    const pthread_barrierattr_t *, int *);
+		    const pthread_barrierattr_t * __restrict, int * __restrict);
 int		pthread_barrierattr_init(pthread_barrierattr_t *);
 int		pthread_barrierattr_setpshared(pthread_barrierattr_t *, int);
 
@@ -191,24 +191,27 @@ int		pthread_barrierattr_setpshared(pthread_barrierattr_t *, int);
 		}
 
 int		pthread_condattr_destroy(pthread_condattr_t *);
-int		pthread_condattr_getclock(const pthread_condattr_t *,
-		    clockid_t *);
+int		pthread_condattr_getclock(const pthread_condattr_t * __restrict,
+		    clockid_t * __restrict);
 int		pthread_condattr_getpshared(const pthread_condattr_t *, int *);
 int		pthread_condattr_init(pthread_condattr_t *);
 int		pthread_condattr_setclock(pthread_condattr_t *, clockid_t);
 int		pthread_condattr_setpshared(pthread_condattr_t *, int);
 int		pthread_cond_broadcast(pthread_cond_t *);
 int		pthread_cond_destroy(pthread_cond_t *);
-int		pthread_cond_init(pthread_cond_t *, const pthread_condattr_t *);
+int		pthread_cond_init(pthread_cond_t * __restrict,
+		    const pthread_condattr_t * __restrict);
 int		pthread_cond_signal(pthread_cond_t *);
 int		pthread_cond_timedwait(pthread_cond_t *,
 		    pthread_mutex_t * __mutex,
 		    const struct timespec *)
 		    __requires_exclusive(*__mutex);
-int		pthread_cond_wait(pthread_cond_t *, pthread_mutex_t * __mutex)
+int		pthread_cond_wait(pthread_cond_t * __restrict,
+		    pthread_mutex_t * __restrict __mutex)
 		    __requires_exclusive(*__mutex);
-int		pthread_create(pthread_t *, const pthread_attr_t *,
-		    void *(*) (void *), void *);
+int		pthread_create(pthread_t * __restrict,
+		    const pthread_attr_t * __restrict, void *(*) (void *),
+		    void * __restrict);
 int		pthread_detach(pthread_t);
 int		pthread_equal(pthread_t, pthread_t);
 void		pthread_exit(void *) __dead2;
@@ -219,40 +222,44 @@ int		pthread_key_create(pthread_key_t *, void (*) (void *));
 int		pthread_key_delete(pthread_key_t);
 int		pthread_mutexattr_init(pthread_mutexattr_t *);
 int		pthread_mutexattr_destroy(pthread_mutexattr_t *);
-int		pthread_mutexattr_getpshared(const pthread_mutexattr_t *,
-		    int *);
-int		pthread_mutexattr_gettype(pthread_mutexattr_t *, int *);
+int		pthread_mutexattr_getpshared(
+		    const pthread_mutexattr_t * __restrict,
+		    int * __restrict);
+int		pthread_mutexattr_gettype(
+		    const pthread_mutexattr_t * __restrict, int * __restrict);
 int		pthread_mutexattr_settype(pthread_mutexattr_t *, int);
 int		pthread_mutexattr_setpshared(pthread_mutexattr_t *, int);
 int		pthread_mutex_consistent(pthread_mutex_t * __mutex)
 		    __requires_exclusive(*__mutex);
 int		pthread_mutex_destroy(pthread_mutex_t * __mutex)
 		    __requires_unlocked(*__mutex);
-int		pthread_mutex_init(pthread_mutex_t * __mutex,
-		    const pthread_mutexattr_t *)
+int		pthread_mutex_init(pthread_mutex_t * __restrict __mutex,
+		    const pthread_mutexattr_t * __restrict)
 		    __requires_unlocked(*__mutex);
 int		pthread_mutex_lock(pthread_mutex_t * __mutex)
 		    __locks_exclusive(*__mutex);
 int		pthread_mutex_trylock(pthread_mutex_t * __mutex)
 		    __trylocks_exclusive(0, *__mutex);
-int		pthread_mutex_timedlock(pthread_mutex_t * __mutex,
-		    const struct timespec *)
+int		pthread_mutex_timedlock(pthread_mutex_t * __restrict __mutex,
+		    const struct timespec * __restrict)
 		    __trylocks_exclusive(0, *__mutex);
 int		pthread_mutex_unlock(pthread_mutex_t * __mutex)
 		    __unlocks(*__mutex);
 int		pthread_once(pthread_once_t *, void (*) (void));
 int		pthread_rwlock_destroy(pthread_rwlock_t * __rwlock)
 		    __requires_unlocked(*__rwlock);
-int		pthread_rwlock_init(pthread_rwlock_t * __rwlock,
-		    const pthread_rwlockattr_t *)
+int		pthread_rwlock_init(pthread_rwlock_t * __restrict __rwlock,
+		    const pthread_rwlockattr_t * __restrict)
 		    __requires_unlocked(*__rwlock);
 int		pthread_rwlock_rdlock(pthread_rwlock_t * __rwlock)
 		    __locks_shared(*__rwlock);
-int		pthread_rwlock_timedrdlock(pthread_rwlock_t * __rwlock,
-		    const struct timespec *)
+int		pthread_rwlock_timedrdlock(
+		    pthread_rwlock_t * __restrict __rwlock,
+		    const struct timespec * __restrict)
 		    __trylocks_shared(0, *__rwlock);
-int		pthread_rwlock_timedwrlock(pthread_rwlock_t * __rwlock,
-		    const struct timespec *)
+int		pthread_rwlock_timedwrlock(
+		    pthread_rwlock_t * __restrict __rwlock,
+		    const struct timespec * __restrict)
 		    __trylocks_exclusive(0, *__rwlock);
 int		pthread_rwlock_tryrdlock(pthread_rwlock_t * __rwlock)
 		    __trylocks_shared(0, *__rwlock);
@@ -265,8 +272,9 @@ int		pthread_rwlock_wrlock(pthread_rwlock_t * __rwlock)
 int		pthread_rwlockattr_destroy(pthread_rwlockattr_t *);
 int		pthread_rwlockattr_getkind_np(const pthread_rwlockattr_t *,
 		    int *);
-int		pthread_rwlockattr_getpshared(const pthread_rwlockattr_t *,
-		    int *);
+int		pthread_rwlockattr_getpshared(
+		    const pthread_rwlockattr_t * __restrict,
+		    int * __restrict);
 int		pthread_rwlockattr_init(pthread_rwlockattr_t *);
 int		pthread_rwlockattr_setkind_np(pthread_rwlockattr_t *,
 		    int);
@@ -295,30 +303,39 @@ int		pthread_setprio(pthread_t, int);
 void		pthread_yield(void);
 #endif
 
-int		pthread_mutexattr_getprioceiling(pthread_mutexattr_t *, int *);
+int		pthread_mutexattr_getprioceiling(
+		    const pthread_mutexattr_t * __restrict,
+		    int * __restrict);
 int		pthread_mutexattr_setprioceiling(pthread_mutexattr_t *, int);
-int		pthread_mutex_getprioceiling(pthread_mutex_t *, int *);
-int		pthread_mutex_setprioceiling(pthread_mutex_t *, int, int *);
+int		pthread_mutex_getprioceiling(const pthread_mutex_t * __restrict,
+		    int * __restrict);
+int		pthread_mutex_setprioceiling(pthread_mutex_t * __restrict, int,
+		    int * __restrict);
 
-int		pthread_mutexattr_getprotocol(pthread_mutexattr_t *, int *);
+int		pthread_mutexattr_getprotocol(
+		    const pthread_mutexattr_t * __restrict,
+		    int * __restrict);
 int		pthread_mutexattr_setprotocol(pthread_mutexattr_t *, int);
 
 int		pthread_mutexattr_getrobust(
 		    pthread_mutexattr_t * __restrict, int * __restrict);
 int		pthread_mutexattr_setrobust(pthread_mutexattr_t *, int);
 
-int		pthread_attr_getinheritsched(const pthread_attr_t *, int *);
+int		pthread_attr_getinheritsched(const pthread_attr_t * __restrict,
+		    int * __restrict);
 int		pthread_attr_getschedparam(const pthread_attr_t *,
 		    struct sched_param *);
-int		pthread_attr_getschedpolicy(const pthread_attr_t *, int *);
-int		pthread_attr_getscope(const pthread_attr_t *, int *);
+int		pthread_attr_getschedpolicy(const pthread_attr_t * __restrict,
+		    int * __restrict);
+int		pthread_attr_getscope(const pthread_attr_t * __restrict,
+		    int * __restrict);
 int		pthread_attr_setinheritsched(pthread_attr_t *, int);
 int		pthread_attr_setschedparam(pthread_attr_t *,
 		    const struct sched_param *);
 int		pthread_attr_setschedpolicy(pthread_attr_t *, int);
 int		pthread_attr_setscope(pthread_attr_t *, int);
-int		pthread_getschedparam(pthread_t pthread, int *,
-		    struct sched_param *);
+int		pthread_getschedparam(pthread_t pthread, int * __restrict,
+		    struct sched_param * __restrict);
 int		pthread_setschedparam(pthread_t, int,
 		    const struct sched_param *);
 #if __XSI_VISIBLE