path: root/UPDATING
diff options
authorWarner Losh <imp@FreeBSD.org>2020-08-07 16:26:56 +0000
committerWarner Losh <imp@FreeBSD.org>2020-08-07 16:26:56 +0000
commit33176cdc87a6c7d2993b4e6b95e9ce8b016454b4 (patch)
treec4b9f2f7c4519cdc515542695b5ffc0b2e800aa0 /UPDATING
parent1f325602e470231d230d79526e98c4000403ca41 (diff)
The practice of creating symbolic links is somewhat fragile. Always
make copies instead. There's too many times that we can't run the new binaries with old libraries. Making the links when things are known to be 'safe' is a nice optimization, but a copy of all the binaries is only 30MB, so saving the copies at the cost of increased support when new symbols are added and used as part of the bootstrap seems to be unwise. There may be additional optimizations possible here, especially for !FreeBSD hosts. However, that's beyond the scope of the problem I'm trying to fix with make failing mid-way through an installworld across change r363679. This optimization there caused us to run a new binary with an old library once a new make was installed due to the symbolic link. One could just copy make, but then other binaries fail as well, so rather than play whack-a-mole, I opted to take us back to the old way. Before r340157 or so we did copies (thogh of a lot fewer artifacts), and we didn't have issues like this. Reviewed by: arichards@ Differential Revision: https://reviews.freebsd.org/D25967
Notes: svn path=/head/; revision=364030
Diffstat (limited to 'UPDATING')
1 files changed, 6 insertions, 0 deletions
diff --git a/UPDATING b/UPDATING
index 9cd27c5f4f37..206953b5b37b 100644
@@ -26,6 +26,12 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 13.x IS SLOW:
disable the most expensive debugging functionality run
"ln -s 'abort:false,junk:false' /etc/malloc.conf".)
+ Makefile.inc has been updated to work around the issue documented in
+ 20200729. It was a case where the optimization of using symbolic links
+ to point to binaries created a situation where we'd run new binaries
+ with old libraries starting midway through the installworld process.
r363679 has redefined some undefined behavior in regcomp(3); notably,
extraneous escapes of most ordinary characters will no longer be